fix(web): consume plans on new-thread implementation#1203
Open
UtkarshUsername wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(web): consume plans on new-thread implementation#1203UtkarshUsername wants to merge 1 commit intopingdotgg:mainfrom
UtkarshUsername wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:XS
3 tasks
binbandit
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978
Continues #1133 (see https://pr-navigator.pages.dev/t3code-utkarsh).
What Changed
This extends plan consumption to the
Implement in a new threadflow #1133.PR 1133 introduced the shared plan-consumption plumbing and applied it to same-thread
Implement. This PR wires the remaining caller: when the user choosesImplement in a new thread, the new thread’sthread.turn.startcommand now includessourceProposedPlan.That allows the existing orchestration and runtime-ingestion path to mark the source proposed plan as implemented when the new thread’s implementation turn actually starts, so the original plan thread no longer has the "Plan Ready" label.
Why
Before this change, the same-thread implementation flow consumed the plan, but the new-thread implementation flow still started an implementation turn without identifying which source plan it came from.
That left the original thread in a stale "Plan Ready" state even though the plan was already being implemented elsewhere.
This PR keeps the behavior consistent across both implementation entrypoints by reusing the same source-plan mechanism introduced in PR 1133.
UI Changes
Combined the before/after videos and posted it on X because the files' sizes were too large to upload here: https://x.com/UtkarshUsername/status/2033161459447087223?s=20
PR Context
This PR continues on top of:
fix/consume-plan-on-same-thread-implementationSee https://pr-navigator.pages.dev/t3code-utkarsh.
Made this a different PR because it solves a different pre-existing problem. Actually, I had solved this first, but changed the order to make reviewing easier.
Checklist
Note
Include
sourceProposedPlanmetadata in orchestration dispatch for new-thread flowWhen starting a new thread from a proposed plan, the orchestration action payload in ChatView.tsx now includes a
sourceProposedPlanobject carrying the originatingthreadIdandplanId. This ensures the plan is consumed/associated correctly when a thread is created from it.Macroscope summarized 2617a99.